Skip to content

London | 25-ITP-Sep | Payman Issa Baiglu | sprint 3 | 1- implement-and-rewrite #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 34 commits into from
Closed

London | 25-ITP-Sep | Payman Issa Baiglu | sprint 3 | 1- implement-and-rewrite #882

wants to merge 34 commits into from

Conversation

@PaymanIB
Copy link

@PaymanIB PaymanIB commented Nov 15, 2025

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Assertions and tests with jest are completed.

Payman IB and others added 29 commits November 1, 2025 11:32
1-key-errors,0.js, completed
2c6aae7
Fix variable shadowing in capitalise function and update console log;…
876bf7b 
… correct convertToPercentage function implementation
Fix function definition and error explanations in square function exa…
058c055 
…mple
Fix multiply function to return value and update
c8cebbb
Fix sum function to return correct value and update console log
a5bdca3
Fix getLastDigit function to accept parameter and return correct last…
7ea670b 
… digit
Implement BMI calculation function and log result
f5b79bf
Fix console log statement formatting in BMI calculation
b760859
Implement toUpperSnakeCase function to convert strings to UPPER_SNAKE…
1f37466 
…_CASE
Implement toPounds function to convert pence to pounds and log results
e943a03
Refactor comments and formatting in time-format.js for clarity
5f29b84
Refactor formatAs12HourClock function to improve time validation and …
8ecd330 
…formatting
Update comment to clarify syntax error in capitalise function
0e37a64
updated the answer on line 4.
cd942b8
Remove redundant comments and clarify the capitalise function impleme…
906778c 
…ntation
Fix indentation in commented-out code for clarity in convertToPercent…
ed909e1 
…age function
Update comment to clarify explanation of return statement in sum func…
d486397 
…tion
Remove redundant declaration of decimalNumber in convertToPercentage …
6eb8b88 
…function
Refactor convertToPercentage function to return percentage directly
62492e1
Fix prediction comment in 2.js to accurately reflect expected output
25347a2
Refactor toPounds function for improved readability and consistency
ba8d606
Remove unnecessary comments in formatTimeDisplay function for cleaner…
b185d08 
… code
@PaymanIB
Delete Sprint-2/2-mandatory-debug/new.js
c335f18
Refactor code structure for improved readability and maintainability
696a379
Refactor isProperFraction function to use absolute values for proper …
90a9885 
…fraction checks and add missing assertions for test cases
Implement getCardValue function to return numerical values for playin…
a2adf3d 
…g cards and handle invalid ranks
Implement Jest testing framework and coverage reporting
edfe97e 
- Added Jest configuration files for multiple projects.
- Implemented setupTests.js for initializing test environment.
- Included favicon and sorting functionality in coverage reports.
- Established test environment as Node for all configurations.
- Enabled coverage collection and specified coverage directories.
Add additional test cases for isProperFraction function to cover impr…
1d68450 
…oper fractions and negative scenarios
Add tests for getCardValue function to cover number cards, face cards…
4ea61d3 
…, Ace, and invalid ranks
@PaymanIB PaymanIB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 15, 2025
@PaymanIB PaymanIB closed this Nov 15, 2025
@PaymanIB PaymanIB deleted the coursework/sprint-3-implement-and-rewrite branch November 15, 2025 14:08
@PaymanIB PaymanIB restored the coursework/sprint-3-implement-and-rewrite branch November 15, 2025 15:49
@PaymanIB PaymanIB reopened this Nov 15, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Nov 21, 2025

This PR branch contains a lot of changed files unrelated to Sprint-3 exercise.
You can see all the "changed files" here: https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/882/files

Can you revert all unrelated changes? You can also close this PR, create a new branch and transfer your Sprint-3 exercise files to the new branch, and then submit a new PR.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 21, 2025
@PaymanIB
Copy link
Author

PaymanIB commented Nov 22, 2025

Thank you @cjyuan for reviewing my PR. I reverted back the unrelated files. can you please check it now.

@PaymanIB PaymanIB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 22, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Nov 22, 2025

There are still a lot of unrelated changes in this branch. One of the reasons is that "reverting changes by editing the file" is not the best way to produce a file that is identical to the original file; files differ by even one space or newline character are still considered different files.

If time is a concern, feel free to create a new branch (from main), transfer your change there, and submit a new PR and close this PR.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 22, 2025
@PaymanIB
Copy link
Author

PaymanIB commented Nov 22, 2025

Thank you @cjyuan , I made a new branch and moved the related files there. Made a new PR with the same name. Could you please check that one. I appreciate you help.

@PaymanIB PaymanIB closed this Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaymanIB @cjyuan